Conversation
phroi
force-pushed
the
prelim/stack-review-followups
branch
from
af8da47 to
5c1756b
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refines the iCKB stack by correcting DAO withdrawal readiness logic, enhancing order resolution to prefer newly minted states, and transitioning the SDK to direct deposit scans for maturity estimation. It introduces a shared isPlainCapacityCell utility, optimizes the interface's deposit selection algorithm, and updates documentation for the bot's rebalancing policy. Additionally, the PR expands test coverage and updates the Node.js engine requirement to version 22. I have no feedback to provide.
phroi
force-pushed
the
prelim/stack-review-followups
branch
2 times, most recently
from
e889f09 to
e111913
Compare
phroi
force-pushed
the
prelim/stack-review-followups
branch
from
e111913 to
c14c72f
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request formalizes the bot rebalancing policy and refines the handling of deposit capacities and maturity estimates across the stack. Significant updates include transitioning the SDK from snapshot-based estimation to direct deposit scanning, optimizing the selectReadyDeposits algorithm using a subset-sum approach, and ensuring receipts track free capacity rather than total capacity. Documentation was updated to reflect current runtime behaviors versus archived improvement ideas. Review feedback identifies several improvement opportunities: optimizing performance by reducing sequential RPC calls in loops, removing redundant manual filters that are already covered by API query parameters, and preferring native Math functions over custom utility helpers to simplify the codebase.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the bot rebalancing policy, updates documentation, and transitions the SDK from pool snapshots to direct deposit scans for maturity estimation. It also introduces a more sophisticated subset selection algorithm for ready deposits and centralizes cell validation logic. A critical issue was identified in the ReceiptData prefix decoding, where the hex slice length is insufficient to capture the required 24 bytes of data, which will likely cause decoding failures.
|
LGTM Phroi %150 |
1 participant
Why
The stack had several follow-up correctness issues after the CCC migration work landed. The main problems were around liquidity accounting, DAO readiness, order-lineage resolution, and interface preview behavior. This PR fixes those runtime issues first, adds the matching tests at the owning layers, and then separates live behavior docs from future implementation ideas.
Changes